Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424741

Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert init function to return error

Show all headers | View raw

On 16/06/16 22:26, Daniel Lezcano wrote:
> The init functions do not return any error. They behave as the following:
> 
>   - panic, thus leading to a kernel crash while another timer may work and
>        make the system boot up correctly
> 
>   or
> 
>   - print an error and let the caller unaware if the state of the system
> 
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
> 
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/clocksource/tegra20_timer.c | 28 ++++++++++++++++------------
>  1 file changed, 16 insertions(+), 12 deletions(-)

The $subject does not appear to match with the driver you are modifying
here.

Cheers
Jon

-- 
nvpublic

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-16 23:30 +0200
  Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert  init function to return error Jon Hunter <jonathanh@nvidia.com> - 2016-06-17 09:30 +0200
    Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert  init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-17 10:10 +0200
    [PATCH V3] clocksource/drivers/tegra20: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-17 11:10 +0200

csiph-web