Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424779

Re: [PATCH v2 7/7] mm/page_alloc: introduce post allocation processing on page allocator

Show all headers | View raw

On Mon, Jun 06, 2016 at 05:21:45PM +0200, Vlastimil Babka wrote:
> On 05/26/2016 04:37 AM, js1304@gmail.com wrote:
> >From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >
> >This patch is motivated from Hugh and Vlastimil's concern [1].
> >
> >There are two ways to get freepage from the allocator. One is using
> >normal memory allocation API and the other is __isolate_free_page() which
> >is internally used for compaction and pageblock isolation. Later usage is
> >rather tricky since it doesn't do whole post allocation processing
> >done by normal API.
> >
> >One problematic thing I already know is that poisoned page would not be
> >checked if it is allocated by __isolate_free_page(). Perhaps, there would
> >be more.
> >
> >We could add more debug logic for allocated page in the future and this
> >separation would cause more problem. I'd like to fix this situation
> >at this time. Solution is simple. This patch commonize some logic
> >for newly allocated page and uses it on all sites. This will solve
> >the problem.
> >
> >[1] http://marc.info/?i=alpine.LSU.2.11.1604270029350.7066%40eggly.anvils%3E
> >
> >Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> 
> Yes that's much better. Hopefully introducing a function call into
> prep_new_page() (or can compiler still inline it there?) doesn't
> impact the fast paths though.

Looks like it is already inlined in my build environment but I will
add inline attribute.

> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 7/7] mm/page_alloc: introduce post allocation  processing on page allocator Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-06-17 10:00 +0200

csiph-web