Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424756

Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page()

Show all headers | View raw

Andrew,

Am 17.06.2016 um 01:11 schrieb Andrew Morton:
> On Thu, 16 Jun 2016 23:26:13 +0200 Richard Weinberger <richard@nod.at> wrote:
> 
>> While block oriented filesystems use buffer_migrate_page()
>> as page migration function other filesystems which don't
>> implement ->migratepage() will automatically get fallback_migrate_page()
>> assigned. fallback_migrate_page() is not as generic as is should
>> be. Page migration is filesystem specific and a one-fits-all function
>> is hard to achieve. UBIFS leaned this lection the hard way.
>> It uses various page flags and fallback_migrate_page() does not
>> handle these flags as UBIFS expected.
>>
>> To make sure that no further filesystem will get confused by
>> fallback_migrate_page() disable the automatic assignment and
>> allow filesystems to use this function explicitly if it is
>> really suitable.
> 
> hm, is there really much point in doing this?  I assume it doesn't
> actually affect any current filesystems?

Well, we simply don't know which filesystems are affected by similar issues.
JFFS2 is maybe also affected since it is not block based.
For UBIFS it also worked many years.

> [2/3] is of course OK - please add it to the UBIFS tree.

Can I add your Acked-by?

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger <richard@nod.at> - 2016-06-16 23:30 +0200
  Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Andrew Morton <akpm@linux-foundation.org> - 2016-06-17 01:20 +0200
    Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger <richard@nod.at> - 2016-06-17 09:50 +0200
      Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Michal Hocko <mhocko@kernel.org> - 2016-06-17 18:30 +0200
        Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger <richard@nod.at> - 2016-06-17 19:00 +0200
          Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Michal Hocko <mhocko@kernel.org> - 2016-06-17 20:30 +0200
            Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger <richard@nod.at> - 2016-06-17 21:40 +0200
              Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Michal Hocko <mhocko@kernel.org> - 2016-06-17 22:10 +0200
    Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger <richard@nod.at> - 2016-06-23 00:30 +0200

csiph-web