Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424621

Re: [PATCH v2 8/8] p54: convert to sysdata API

Show all headers | View raw

On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>
> Reason this could not wait is folks seem to want to keep extending the API,
> which is another reason for this, do we want to put an end to an unflexible
> API now or should we wait ?

So I absolutely abhor "changes for changes sake".

If the existing code works for existing drivers, let them keep it.

And if a new interface is truly more flexible, then it should be able
to implement the old interface with no changes, so that drivers
shouldn't need to be changed/upgraded.

Then, drivers that actually _want_ new features, or that can take
advantage of new interfaces to actually make things *simpler*, can
choose to make those changes. But those changes should have real
advantages.

Having to have a callback, or a magical "sysdata_desc" descriptor, and
having a new name ("sysdata") that is less descriptive than the old
one ("firmware") are all in my opinion making the example patch be a
step _backwards_ rather than an improvement. It does not look like a
simpler or more natural interface for a driver.

               Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] firmware: add new sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:00 +0200
  [PATCH v2 6/8] Documentation/firmware_class: add sysdata API converter SmPL patch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:00 +0200
  [PATCH v2 3/8] selftests: firmware: only modprobe if driver is missing "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:10 +0200
  [PATCH v2 7/8] x86/microcode: convert to use sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:10 +0200
  [PATCH v2 1/8] firmware: add new extensible firmware API - sysdata_file_request*() "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:10 +0200
  [PATCH v2 8/8] p54: convert to sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 02:10 +0200
    Re: [PATCH v2 8/8] p54: convert to sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 03:40 +0200
      Re: [PATCH v2 8/8] p54: convert to sysdata API Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-17 05:10 +0200
        Re: [PATCH v2 8/8] p54: convert to sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-17 20:40 +0200
  Re: [PATCH v2 0/8] firmware: add new sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-18 01:50 +0200
    Re: [PATCH v2 0/8] firmware: add new sysdata API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-18 02:40 +0200

csiph-web