Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424498

Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit

From Bandan Das <bsd@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit
Date 2016-06-17 00:10 +0200
Message-ID <rKNE5-5vQ-1@gated-at.bofh.it> (permalink)
References <rKAQx-5Ue-7@gated-at.bofh.it> <rKAQy-5Ue-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

...
>  static bool vmx_has_high_real_mode_segbase(void)
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 7e3041ef050f..cc741b68139c 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -6706,21 +6706,13 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
>  
>  	kvm_put_guest_xcr0(vcpu);
>  
> -	/* Interrupt is enabled by handle_external_intr() */
>  	kvm_x86_ops->handle_external_intr(vcpu);
>  
>  	++vcpu->stat.exits;
>  
> -	/*
> -	 * We must have an instruction between local_irq_enable() and
> -	 * kvm_guest_exit(), so the timer interrupt isn't delayed by
> -	 * the interrupt shadow.  The stat.exits increment will do nicely.
> -	 * But we need to prevent reordering, hence this barrier():
> -	 */
> -	barrier();
> -
> -	kvm_guest_exit();
> +	__kvm_guest_exit();

kvm_guest_exit has no more callers and so can be removed.

Bandan

> +	local_irq_enable();
>  	preempt_enable();
>  
>  	vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] KVM: x86: guest exit microoptimization Paolo Bonzini <pbonzini@redhat.com> - 2016-06-16 10:30 +0200
  [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit Paolo Bonzini <pbonzini@redhat.com> - 2016-06-16 10:30 +0200
    Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit David Matlack <dmatlack@google.com> - 2016-06-16 18:50 +0200
      Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit Paolo Bonzini <pbonzini@redhat.com> - 2016-06-16 18:50 +0200
        Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit David Matlack <dmatlack@google.com> - 2016-06-16 19:10 +0200
          Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit Paolo Bonzini <pbonzini@redhat.com> - 2016-06-16 19:30 +0200
    Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit Bandan Das <bsd@redhat.com> - 2016-06-17 00:10 +0200
      Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit Paolo Bonzini <pbonzini@redhat.com> - 2016-06-17 07:30 +0200

csiph-web