RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

From	"Odzioba, Lukasz" <lukasz.odzioba@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date	2016-06-16 22:10 +0200
Message-ID	<rKLLX-4lm-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <rHOdj-2nA-13@gated-at.bofh.it> <rHOGl-2xG-15@gated-at.bofh.it> <rI7fX-6hH-7@gated-at.bofh.it> <rKJTP-3eJ-17@gated-at.bofh.it> <rKK3w-3hY-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 16-06-16 08:19 PM, Michal Hocko wrote:
>
> On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote:
> I am not able to find clear reasons why we shouldn't do it for the rest.
> Ok so what do we do now? I'll send v2 with proposed changes.
> Then do we still want  to have stats on those pvecs?
> In my opinion it's not worth it now.
>
> I think the fix has a higher priority - we also want to backport it to
> stable trees IMO. We can discuss the stats and how to present them
> later.

Will send the patch tomorrow. In the meantime I was able get similar
problem on lru_deactivate by using MADV_FREE:

LRU_add              588 =    18704kB
LRU_rotate             0 =        0kB
LRU_deactivate       165 =   309304kB
LRU_deact_file         0 =        0kB
LRU_activate           0 =        0kB

Thanks,
Lukas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-06-16 20:10 +0200
  Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Michal Hocko <mhocko@kernel.org> - 2016-06-16 20:20 +0200
    RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-06-16 22:10 +0200

csiph-web