Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1424330

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date 2016-06-16 20:10 +0200
Message-ID <rKJTP-3eJ-9@gated-at.bofh.it> (permalink)
References <rJvT0-3Sn-13@gated-at.bofh.it> <rKJK9-2Wq-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> On 2016/06/13 11:46, Netanel Belgazal wrote:
[...]
> > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > +				       struct device_attribute *attr, char *buf)
> > +{
> > +	struct ena_adapter *adapter = dev_get_drvdata(dev);
> > +
> > +	return sprintf(buf, "%d\n", adapter->small_copy_len);
> > +}
> > +
> > +static DEVICE_ATTR(small_copy_len, S_IRUGO | S_IWUSR, ena_show_small_copy_len,
> > +		   ena_store_small_copy_len);
> 
> This is what many other drivers call (rx_)copybreak. Perhaps it's time
> to add it to ethtool as well?
[...]

There is the 'tunable' ethtool API for random parameters like
rx_copybreak.  The ethtool utility doesn't support it yet, though.

Ben.

-- 
Ben Hutchings
Life is what happens to you while you're busy making other plans.
                                                               - John
Lennon

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) Benjamin Poirier <benjamin.poirier@gmail.com> - 2016-06-16 20:00 +0200
  Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) Ben Hutchings <ben@decadent.org.uk> - 2016-06-16 20:10 +0200
    Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-18 08:20 +0200

csiph-web