Re: [PATCH 6/8] net: gianfar: fix old-style declaration

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] net: gianfar: fix old-style declaration
Date	2016-06-16 20:10 +0200
Message-ID	<rKJTP-3eJ-1@gated-at.bofh.it> (permalink)
References	<rKFQd-za-9@gated-at.bofh.it> <rKFZU-Cr-9@gated-at.bofh.it> <rKFZU-Cr-19@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello.

On 06/16/2016 04:52 PM, Arnd Bergmann wrote:

> Modern C standards expect the '__inline__' keyword to come before the return
> type in a declaration, and we get a warning for this with "make W=1":
>
> drivers/net/ethernet/freescale/gianfar.c:2278:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/freescale/gianfar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 2e6785b6e8be..d20935dc8399 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -2275,7 +2275,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb,
>  	fcb->flags = flags;
>  }
>
> -void inline gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb)
> +static inline void gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb)

    You don't mention making it *static*. Though the function can be *static* 
indeed... the current policy also forbids *inline* in the *.c files, leaving 
the judgement to gcc.

MBR, Sergei

Thread

[PATCH 0/8] net: fix old-style declarations Arnd Bergmann <arnd@arndb.de> - 2016-06-16 15:50 +0200
  [PATCH 7/8] net: xfrm: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
    Re: [PATCH 7/8] net: xfrm: fix old-style declaration David Miller <davem@davemloft.net> - 2016-06-17 07:10 +0200
  [PATCH 3/8] wireless: ipw2200: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
  [PATCH 1/8] wireless: airo: rename 'register' variable Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
    [PATCH 4/8] hamradio: baycom: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
      Re: [PATCH 4/8] hamradio: baycom: fix old-style declaration David Miller <davem@davemloft.net> - 2016-06-17 07:10 +0200
    [PATCH 6/8] net: gianfar: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
      Re: [PATCH 6/8] net: gianfar: fix old-style declaration Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-06-16 20:10 +0200
        Re: [PATCH 6/8] net: gianfar: fix old-style declaration Joe Perches <joe@perches.com> - 2016-06-16 20:20 +0200
      Re: [PATCH 6/8] net: gianfar: fix old-style declaration David Miller <davem@davemloft.net> - 2016-06-17 07:10 +0200
    [PATCH 2/8] wireless: brcmsmac: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
    [PATCH 5/8] isdn: eicon: fix old-style declarations Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200
      Re: [PATCH 5/8] isdn: eicon: fix old-style declarations David Miller <davem@davemloft.net> - 2016-06-17 07:10 +0200
  [PATCH 8/8] sunrpc: fix old-style declaration Arnd Bergmann <arnd@arndb.de> - 2016-06-16 16:00 +0200

csiph-web