Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument
Date	2016-06-16 20:00 +0200
Message-ID	<rKJK9-2Wq-11@gated-at.bofh.it> (permalink)
References	<rKDOp-7Nv-7@gated-at.bofh.it> <rKDOq-7Nv-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> We get a warning for this when building with W=1 because the
> argument gets assigned to something else but never read:
>
> drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity':
> drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set but not used [-Werror=unused-but-set-parameter]
>
> This remove the argument entirely.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,

I wonder if it'd worth adding this ... even if the word "Completes" would be more
correct than "Fixes" :
Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop")

Apart form that:
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] usb: pxa27x_udc: remove unused function argument Arnd Bergmann <arnd@arndb.de> - 2016-06-16 13:40 +0200
  Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument Robert Jarzmik <robert.jarzmik@free.fr> - 2016-06-16 20:00 +0200

csiph-web