Re: [PATCH v2] of: fix memory leak related to safe_name()

From	Frank Rowand <frowand.list@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] of: fix memory leak related to safe_name()
Date	2016-06-16 19:50 +0200
Message-ID	<rKJAt-2T5-9@gated-at.bofh.it> (permalink)
References	<rKpV7-7iY-13@gated-at.bofh.it> <rKzKN-5hx-21@gated-at.bofh.it> <rKAnw-5uL-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/16/16 00:51, Mathieu Malaterre wrote:
> Sorry, symptoms not solved. According to kmemleak, I have now:
> 
> [  661.323100] kmemleak: 100 new suspected memory leaks (see
> /sys/kernel/debug/kmemleak)
> [ 1260.226120] kmemleak: 1 new suspected memory leaks (see
> /sys/kernel/debug/kmemleak)
> 
> # head -40 /sys/kernel/debug/kmemleak
> unreferenced object 0xdf5326a0 (size 32):
>   comm "swapper", pid 1, jiffies 4294892300 (age 2564.708s)
>   hex dump (first 32 bytes):
>     62 61 73 65 00 00 4c d8 c5 78 df dc cc 43 e4 bc  base..L..x...C..
>     c4 c8 ec 8c ee de ce cf e8 c9 8a ea dc cc c6 fd  ................
>   backtrace:
>     [<c014d4d8>] kstrdup+0x48/0x88
>     [<c0454678>] __of_attach_node_sysfs+0xf0/0x100
>     [<c075f21c>] of_core_init+0x8c/0xf8
>     [<c0729594>] kernel_init_freeable+0xd4/0x208
>     [<c00047e8>] kernel_init+0x24/0x11c
>     [<c00158ec>] ret_from_kernel_thread+0x5c/0x64

< snip >

Brown paper bag time.  I left out the kfree() in the one place that
your first patch added it.  Version 3 on the way.

-Frank

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] of: fix memory leak related to safe_name() Frank Rowand <frowand.list@gmail.com> - 2016-06-15 22:50 +0200
  Re: [PATCH v2] of: fix memory leak related to safe_name() Mathieu Malaterre <mathieu.malaterre@gmail.com> - 2016-06-16 09:20 +0200
    Re: [PATCH v2] of: fix memory leak related to safe_name() Mathieu Malaterre <mathieu.malaterre@gmail.com> - 2016-06-16 10:00 +0200
      Re: [PATCH v2] of: fix memory leak related to safe_name() Frank Rowand <frowand.list@gmail.com> - 2016-06-16 19:50 +0200

csiph-web