Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424221

Re: [v3,1/2] b43: Remove unused phy_a code

Show all headers | View raw

Michael Büsch <m@bues.ch> writes:

> On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
> Kalle Valo <kvalo@codeaurora.org> wrote:
>
>> Guenter Roeck <linux@roeck-us.net> wrote:
>> > gcc-6 reports the following error with -Werror=unused-const-variable.
>> > 
>> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> > 	'b43_phyops_a' defined but not used
>> > 
>> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
>> > and move the remaining Type-G initialization code into phy_g.c.
>> > 
>> > Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
>> > Cc: Michael Büsch <m@bues.ch>
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>  
>> 
>> Thanks, 2 patches applied to wireless-drivers-next.git:
>> 
>> 9791333a840f b43: Remove unused phy_a code
>> afdfdc481ea9 b43: Completely remove support for phy_a
>
> Did anybody test this on any hardware? I think this should be tested
> on some G-PHY hardware, before it goes to Linus.

Larry tested these:

"These two patches have been tested on a BCM4318."

https://patchwork.kernel.org/patch/9154719/

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [v3,1/2] b43: Remove unused phy_a code Michael Büsch <m@bues.ch> - 2016-06-16 17:50 +0200
  Re: [v3,1/2] b43: Remove unused phy_a code Kalle Valo <kvalo@codeaurora.org> - 2016-06-16 18:00 +0200
    Re: [v3,1/2] b43: Remove unused phy_a code Michael Büsch <m@bues.ch> - 2016-06-16 18:10 +0200

csiph-web