Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver
Date	2016-06-16 15:20 +0200
Message-ID	<rKFnc-pe-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <rIzlU-8dw-45@gated-at.bofh.it> <rJZ4B-79l-11@gated-at.bofh.it> <rKf9n-F4-17@gated-at.bofh.it> <rKfsJ-Lj-17@gated-at.bofh.it> <rKpiq-74l-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 15/06/16 21:07, Kenneth Westfield wrote:
> On Wed, Jun 15, 2016 at 10:31:36AM +0100, Mark Brown wrote:
>> On Wed, Jun 15, 2016 at 10:16:27AM +0100, Srinivas Kandagatla wrote:
>>> On 14/06/16 16:59, Mark Brown wrote:
>>>> On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote:
>
>>> In theory there are 3 devices,
>>> one is the pmic-spmi driver, which provides regmap access to analog part of
>>> codec registers.
>>> second is syscon driver which provides regmap access to digital parts of
>>> codec to codec driver.
>>> third is the codec driver which uses both the above.
>>
>>> Codec registers range is just split into two, range 0x0- 0x200 sits in pmic
>>> address space and range 0x201 - 0x4ff in the SOC address space,
>>
>>> Are there any other better ways to model this kinda driver?
>>
>> Why not just have separate devices for each of the register maps?
>
> Srinivas,
>
> Mark has a good point.  Also, by having distinct devices and drivers;
> you should make use of ASoC's supporting wrappers for regmap accesses.

Yep, Let to try that and see how it looks.

thanks,
srini
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Mark Brown <broonie@kernel.org> - 2016-06-14 18:10 +0200
  Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-15 11:20 +0200
    Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Mark Brown <broonie@kernel.org> - 2016-06-15 11:40 +0200
      Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Kenneth Westfield <kwestfie@codeaurora.org> - 2016-06-15 22:10 +0200
        Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-16 15:20 +0200

csiph-web