Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG
Date	2016-06-16 12:40 +0200
Message-ID	<rKCSn-7c3-39@gated-at.bofh.it> (permalink)
References	<rJBEZ-7YP-19@gated-at.bofh.it> <rKleO-4pE-33@gated-at.bofh.it> <rKlou-4sY-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 15 Jun 2016, Andrew F. Davis wrote:

> On 06/15/2016 10:43 AM, Lee Jones wrote:
> > This requires a USB Ack.
> > 
> >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter.
> >> Add MFD core support.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> > 
> > Where is the change log from v1 => v2?
> > 
> 
> Looking at a diff of the two it looks like all the changes are related
> to your v1 feedback:
> 
>  - Rename sm-usb-dig -> ti-smusbdig
>  - Inline helper functions in header
>  - Alphabetize includes

Please ensure this is added when you submit subsequent sets.  It
really does help with the review and saves a great deal of time.

> >> Changes from v2:
> >>  - Add missing dependency on USB, thanks kbuild test robot
> >>
> >>  drivers/mfd/Kconfig             |   9 +++
> >>  drivers/mfd/Makefile            |   2 +
> >>  drivers/mfd/ti-smusbdig.c       | 138 ++++++++++++++++++++++++++++++++++++++++
> >>  include/linux/mfd/ti-smusbdig.h |  75 ++++++++++++++++++++++
> >>  4 files changed, 224 insertions(+)
> >>  create mode 100644 drivers/mfd/ti-smusbdig.c
> >>  create mode 100644 include/linux/mfd/ti-smusbdig.h
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG "Andrew F. Davis" <afd@ti.com> - 2016-06-13 17:10 +0200
  [PATCH v3 2/2] i2c: ti-smusbdig: add TI SM-USB-DIG I2C bus driver "Andrew F. Davis" <afd@ti.com> - 2016-06-13 17:10 +0200
  Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI  SM-USB-DIG Lee Jones <lee.jones@linaro.org> - 2016-06-15 17:50 +0200
    Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI  SM-USB-DIG "Andrew F. Davis" <afd@ti.com> - 2016-06-15 18:00 +0200
      Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI  SM-USB-DIG Lee Jones <lee.jones@linaro.org> - 2016-06-16 12:40 +0200

csiph-web