Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423856

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

Show all headers | View raw

On 06/16/2016 11:22 AM, Vitaly Kuznetsov wrote:
> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count,
> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does
> stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While
> it is definitely possible to fix this particular tool I'm not sure about
> other tools which might be doing the same.
>
> I suggest we remember the "we don't break userspace" rule and revert for
> 4.7 while it's not too late.

I don't think the rule applies to tools such as kdump and crash, or e.g. 
systemtap, that interact with kernel internals even though they are 
technically "userspace". They have to adapt to new kernel versions all 
the time, the internal APIs are not frozen. Otherwise we would be quite 
limited in evolving the kernel...

So even though the change in question is not essential (field rename) 
and reverting wouldn't really hurt technical progress, this is not a 
sufficient reason, IMO. Thus, NAK.

Vlastimil

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-06-16 11:30 +0200
  Re: [PATCH] Revert "mm: rename _count, field of the struct page, to  _refcount" Vlastimil Babka <vbabka@suse.cz> - 2016-06-16 11:40 +0200
  Re: [PATCH] Revert "mm: rename _count, field of the struct page, to  _refcount" Christoph Hellwig <hch@infradead.org> - 2016-06-16 11:40 +0200
    Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-06-16 12:40 +0200
      Re: [PATCH] Revert "mm: rename _count, field of the struct page, to  _refcount" Michal Hocko <mhocko@kernel.org> - 2016-06-16 13:00 +0200
        Re: [PATCH] Revert "mm: rename _count, field of the struct page, to  _refcount" Michal Hocko <mhocko@kernel.org> - 2016-06-16 13:30 +0200
        Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-06-16 13:30 +0200

csiph-web