Re: [PATCH] libnvdimm: use devm_add_action_or_reset()

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] libnvdimm: use devm_add_action_or_reset()
Date	2016-06-16 09:40 +0200
Message-ID	<rKA49-5o9-1@gated-at.bofh.it> (permalink)
References	<rKszD-EE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 15, 2016 at 04:31:55PM -0700, Dan Williams wrote:
> Clean up needless calls to the action routine by letting
> devm_add_action_or_reset() call it automatically.  This does cause the
> disk to registered and immediately unregistered when a memory allocation
> fails, but the block layer should be prepared for such an event.
> 
> Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] libnvdimm: use devm_add_action_or_reset() Dan Williams <dan.j.williams@intel.com> - 2016-06-16 01:40 +0200
  Re: [PATCH] libnvdimm: use devm_add_action_or_reset() Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-16 09:40 +0200

csiph-web