Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

From	Bin Gao <bin.gao@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver
Date	2016-06-15 01:40 +0200
Message-ID	<rK665-35Y-1@gated-at.bofh.it> (permalink)
References	<rIK7E-7w3-5@gated-at.bofh.it> <rJTse-3r2-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote:
> On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote:
> > +static const struct platform_device_id pmic_gpio_id_table[] = {
> > +	{ "bxt_wcove_gpio", },
> > +};
> 
> Do you really need this?
> 
> > +
> > +static struct platform_driver wcove_gpio_driver = {
> > +	.probe = wcove_gpio_probe,
> > +	.remove = wcove_gpio_remove,
> > +	.driver = {
> > +		.name = "wcove_gpio",
> > +	},
> > +	.id_table = pmic_gpio_id_table,
> 
> and this?
> 
> > +};
> > +
> > +module_platform_driver(wcove_gpio_driver);
> > +
> > +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
> > +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> > +MODULE_LICENSE("GPL v2");
> 
> You can add
> 
> MODULE_ALIAS("platform:wcove_gpio");
> 
> to get the module loaded automatically.

Mika,
Thanks for your review. I'll address these in patch v2.

-Bin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-14 12:10 +0200
  Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-06-15 01:40 +0200

csiph-web