Re: [PATCH] init, fix initcall blacklist for modules

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] init, fix initcall blacklist for modules
Date	2016-06-15 00:40 +0200
Message-ID	<rK5a1-2vN-15@gated-at.bofh.it> (permalink)
References	<rJzaa-6dn-17@gated-at.bofh.it> <rJH7I-2Zc-21@gated-at.bofh.it> <rJTse-3r2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 14 Jun 2016 05:59:46 -0400 Prarit Bhargava <prarit@redhat.com> wrote:

> On 06/13/2016 04:59 PM, Rasmus Villemoes wrote:
> > On Mon, Jun 13 2016, Prarit Bhargava <prarit@redhat.com> wrote:
> > 
> >> Sorry ... forgot to cc everyone on the last email.
> >>
> >> P.
> >>
> >> ----8<----
> >>
> >> sprint_symbol_no_offset() returns the string "function_name [module_name]"
> >> where [module_name] is not printed for built in kernel functions.  This
> >> means that the initcall blacklisting code will now always fail when
> > 
> > I was and am pretty sure that %pf ends up using
> > sprint_symbol_no_offset(), so I don't see how this is new. But maybe
> > "now" doesn't refer to c8cdd2be21?
> 
> Oops.  I can see how you read that that way.  No, this isn't caused by or
> "Fixes:" c8cdd2be21.  At some point "%pF" changed its behavior and blacklisting
> module_init() functions stopped working.

Well can we please have a v2 with a complete changelog which identifies
when the regression occurred?  That will help in deciding which kernel
versions need fixing.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] init, fix initcall blacklist for modules Prarit Bhargava <prarit@redhat.com> - 2016-06-13 14:30 +0200
  Re: [PATCH] init, fix initcall blacklist for modules Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-06-13 23:00 +0200
    Re: [PATCH] init, fix initcall blacklist for modules Prarit Bhargava <prarit@redhat.com> - 2016-06-14 12:10 +0200
      Re: [PATCH] init, fix initcall blacklist for modules Andrew Morton <akpm@linux-foundation.org> - 2016-06-15 00:40 +0200

csiph-web