Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface
Date	2016-06-14 23:30 +0200
Message-ID	<rK44i-1Sc-25@gated-at.bofh.it> (permalink)
References	<rJlqy-5ve-41@gated-at.bofh.it> <rK3UB-1OB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote:
> On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote:
> > 3.2.81-rc1 review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > 
> > commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream.
> > 
> > The drivers/infiniband stack uses write() as a replacement for
> > bi-directional ioctl().  This is not safe. There are ways to
> > trigger write calls that result in the return structure that
> > is normally written to user space being shunted off to user
> > specified kernel memory instead.
> > 
> 
> <snip>
> 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > --- a/drivers/infiniband/core/ucm.c
> > +++ b/drivers/infiniband/core/ucm.c
> > @@ -48,6 +48,7 @@
> > 
> >   #include <asm/uaccess.h>
> > 
> > +#include <rdma/ib.h>
> 
> This is breaking the build. There is no rdma/ib.h .

This backported patch adds it.

>  The file was created by:
> 8d36eb01da5d ("RDMA/cma: Define native IB address")
> 
> build log is at: https://gitlab.com/sudipm/linux-next/builds/1771265

It looks like your patch queue tester doesn't account for patches that
create new files.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert
Camus

Thread

[PATCH 3.2 31/46] IB/security: Restrict use of the write() interface Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
  Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-14 23:20 +0200
    Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write()  interface Ben Hutchings <ben@decadent.org.uk> - 2016-06-14 23:30 +0200
      Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-15 00:10 +0200

csiph-web