Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3
Date	2016-06-14 22:30 +0200
Message-ID	<rK38d-1hi-1@gated-at.bofh.it> (permalink)
References	<rK1J7-fP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/14/2016 11:52 AM, Shrikrishna Khare wrote:
> This patchset upgrades vmxnet3 to version 3.
> 
> Changes in v2:
>  - Following patch is updated. See that patch for details:
>    vmxnet3: add support for get_coalesce, set_coalesce ethtool
> 
> Changes in v3:
>  - fix subject line to use vmxnet3: instead of Driver:Vmxnet3
>  - resubmit when net-next is open
> 
> Changes in v4:
>  - Following patch is updated. See that patch for details:
>    vmxnet3: add support for get_coalesce, set_coalesce ethtool

You really need to improve your commit messages, because right now they
are inexistent or too obvious to be of any value. A reviewer must be
introduced to what code changes he/she is going to review next by
looking at the diff and whether this will match or not the description
that was provided in the commit message.
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v4 0/7] vmxnet3: upgrade to version 3 Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 7/7] vmxnet3: update to version 3 Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 1/7] vmxnet3: prepare for version 3 changes Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 4/7] vmxnet3: add receive data ring support Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 2/7] vmxnet3: introduce generic command interface to configure the device Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 3/7] vmxnet3: allow variable length transmit data ring buffer Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 6/7] vmxnet3: introduce command to register memory region Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
  [PATCH net-next v4 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations Shrikrishna Khare <skhare@vmware.com> - 2016-06-14 21:00 +0200
    Re: [PATCH net-next v4 5/7] vmxnet3: add support for get_coalesce,  set_coalesce ethtool operations Ben Hutchings <ben@decadent.org.uk> - 2016-06-14 21:40 +0200
  Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3 Florian Fainelli <f.fainelli@gmail.com> - 2016-06-14 22:30 +0200

csiph-web