Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1422259

Re: [RFC][PATCH 8/8] rtmutex: Fix PI chain order integrity

Show all headers | View raw

On Tue, Jun 14, 2016 at 06:39:08PM +0100, Juri Lelli wrote:
> On 07/06/16 21:56, Peter Zijlstra wrote:
> > rt_mutex_waiter::prio is a copy of task_struct::prio which is updated
> > during the PI chain walk, such that the PI chain order isn't messed up
> > by (asynchronous) task state updates.
> > 
> > Currently rt_mutex_waiter_less() uses task state for deadline tasks;
> > this is broken, since the task state can, as said above, change
> > asynchronously, causing the RB tree order to change without actual
> > tree update -> FAIL.
> > 
> > Fix this by also copying the deadline into the rt_mutex_waiter state
> > and updating it along with its prio field.
> > 
> > Ideally we would also force PI chain updates whenever DL tasks update
> > their deadline parameter, but for first approximation this is less
> > broken than it was.
> > 
> 
> The patch looks OK to me. However, I'm failing to see when we can update
> dl.deadline of a waiter asynchronously. Since a waiter is blocked, we
> can't really change his dl.deadline by calling setscheduler on him, as
> the update would operate on dl.dl_deadline. The new values will start to
> be used as soon as it gets unblocked. The situation seems different for
> RT tasks, for which priority change takes effect immediately.
> 
> What am I missing? :-)

Ah, I missed the dl_deadline vs deadline thing. Still, with optimistic
spinning the waiter could hit its throttle/refresh path, right? And then
that would update deadline.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 8/8] rtmutex: Fix PI chain order integrity Juri Lelli <juri.lelli@arm.com> - 2016-06-14 19:40 +0200
  Re: [RFC][PATCH 8/8] rtmutex: Fix PI chain order integrity Peter Zijlstra <peterz@infradead.org> - 2016-06-14 21:50 +0200
    Re: [RFC][PATCH 8/8] rtmutex: Fix PI chain order integrity Juri Lelli <juri.lelli@arm.com> - 2016-06-15 09:30 +0200

csiph-web