Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420803

[PATCH 1/3] infiniband: rxe: avoid 64-bit division

Show all headers | View raw

The rxe driver fails to build on 32-bit because of a 64-bit division:

In function `rxe_qp_from_attr':
:(.text+0x53158): undefined reference to `__aeabi_uldivmod'

We can easily avoid this division by converting the nanosecond value
into jiffies directly rather than converting to microseconds first.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/infiniband/hw/rxe/rxe_qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/rxe/rxe_qp.c b/drivers/infiniband/hw/rxe/rxe_qp.c
index aa11ac3032b2..4e7b0985aab8 100644
--- a/drivers/infiniband/hw/rxe/rxe_qp.c
+++ b/drivers/infiniband/hw/rxe/rxe_qp.c
@@ -664,7 +664,7 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask,
 			qp->qp_timeout_jiffies = 0;
 		} else {
 			/* According to the spec, timeout = 4.096 * 2 ^ attr->timeout [us] */
-			int j = usecs_to_jiffies((4096ULL << attr->timeout) / 1000);
+			int j = nsecs_to_jiffies(4096ULL << attr->timeout);
 
 			qp->qp_timeout_jiffies = j ? j : 1;
 		}
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] infiniband: rxe: avoid 64-bit division Arnd Bergmann <arnd@arndb.de> - 2016-06-13 15:00 +0200
  [PATCH 3/3] infiniband: rxe: fix 32-bit build warnings Arnd Bergmann <arnd@arndb.de> - 2016-06-13 15:00 +0200
    Re: [PATCH 3/3] infiniband: rxe: fix 32-bit build warnings Moni Shoua <monis@mellanox.com> - 2016-06-13 17:30 +0200
  Re: [PATCH 1/3] infiniband: rxe: avoid 64-bit division Leon Romanovsky <leon@kernel.org> - 2016-06-13 15:20 +0200
    Re: [PATCH 1/3] infiniband: rxe: avoid 64-bit division Moni Shoua <monis@mellanox.com> - 2016-06-13 17:30 +0200

csiph-web