Groups > linux.kernel > #1420449

RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode

From	Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode
Date	2016-06-13 07:40 +0200
Message-ID	<rJsLn-1UR-3@gated-at.bofh.it> (permalink)
References	<rI1kd-2sF-19@gated-at.bofh.it> <rJsLn-1UR-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Vinod,

> On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote:
> > This patch fixes the below compilation warining.
> > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
> > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> >    segment->hw.control |= XILINX_DMA_BD_SOP;
> >
> > The start of packet (SOP) should be set to the first segment in the
> > desc chain not for the last segment of the desc chain.
> 
> I have applied this after adding Reported by from SFR.

Sorry will fix it next time on wards....

> 
> You should always give credit to folks who report issues.

Sure will fix next time onwards...

Thanks,
Kedar.

Thread

[PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-06-09 08:10 +0200
  RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma  mode Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-06-13 07:40 +0200
  Re: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma  mode Vinod Koul <vinod.koul@intel.com> - 2016-06-13 07:40 +0200

csiph-web