Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420384
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3.2 17/46] usb: hcd: out of bounds access in for_each_companion |
| Date | 2016-06-12 23:50 +0200 |
| Message-ID | <rJlqz-5ve-63@gated-at.bofh.it> (permalink) |
| References | <rJlgS-5q8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
3.2.81-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Robert Dobrowolski <robert.dobrowolski@linux.intel.com> commit e86103a75705c7c530768f4ffaba74cf382910f2 upstream. On BXT platform Host Controller and Device Controller figure as same PCI device but with different device function. HCD should not pass data to Device Controller but only to Host Controllers. Checking if companion device is Host Controller, otherwise skip. Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c @@ -70,6 +70,14 @@ static void companion_common(struct pci_ PCI_SLOT(companion->devfn) != slot) continue; + /* + * Companion device should be either UHCI,OHCI or EHCI host + * controller, otherwise skip. + */ + if (companion->class != CL_UHCI && companion->class != CL_OHCI && + companion->class != CL_EHCI) + continue; + companion_hcd = pci_get_drvdata(companion); if (!companion_hcd) continue;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3.2 00/46] 3.2.81-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
[PATCH 3.2 05/46] crypto: gcm - fix rfc4543 to handle async crypto correctly Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
[PATCH 3.2 17/46] usb: hcd: out of bounds access in for_each_companion Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
[PATCH 3.2 15/46] usb: xhci: fix wild pointers in xhci_mem_cleanup Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
[PATCH 3.2 42/46] get_rock_ridge_filename(): handle malformed NM entries Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
[PATCH 3.2 23/46] s390/hugetlb: add hugepages_supported define Ben Hutchings <ben@decadent.org.uk> - 2016-06-12 23:50 +0200
Re: [PATCH 3.2 00/46] 3.2.81-rc1 review Guenter Roeck <linux@roeck-us.net> - 2016-06-13 01:20 +0200
Re: [PATCH 3.2 00/46] 3.2.81-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2016-06-13 01:50 +0200
Re: [PATCH 3.2 00/46] 3.2.81-rc1 review Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-15 00:00 +0200
Re: [PATCH 3.2 00/46] 3.2.81-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2016-06-15 00:20 +0200
Re: [PATCH 3.2 00/46] 3.2.81-rc1 review Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-15 00:40 +0200
csiph-web