Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420318

[PATCH] dma: remove bad_dma_ops to fix build fail

Show all headers | View raw

m32r allmodconfig is failng with errors like:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

On checking the code it turns out that struct bad_dma_ops has been
declared as extern but no one has actually defined struct bad_dma_ops.
Lets remove that and return NULL from get_dma_ops() if HAS_DMA is not
defined.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

This patch has been build tested with m32r allmodconfig,
x86_64 allmodconfig and i386 allmodconfig.

 include/linux/dma-mapping.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 71c1b21..583795a 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -113,10 +113,9 @@ int dma_mmap_from_coherent(struct device *dev, struct vm_area_struct *vma,
  * dma dependent code.  Code that depends on the dma-mapping
  * API needs to set 'depends on HAS_DMA' in its Kconfig
  */
-extern struct dma_map_ops bad_dma_ops;
 static inline struct dma_map_ops *get_dma_ops(struct device *dev)
 {
-	return &bad_dma_ops;
+	return NULL;
 }
 #endif
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] dma: remove bad_dma_ops to fix build fail Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-12 22:30 +0200
  Re: [PATCH] dma: remove bad_dma_ops to fix build fail Jerry Snitselaar <dev@snitselaar.org> - 2016-06-12 23:50 +0200
    Re: [PATCH] dma: remove bad_dma_ops to fix build fail Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-13 09:50 +0200
      Re: [PATCH] dma: remove bad_dma_ops to fix build fail Mark Brown <broonie@kernel.org> - 2016-06-13 11:30 +0200
        Re: [PATCH] dma: remove bad_dma_ops to fix build fail Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-13 13:00 +0200
          Re: [PATCH] dma: remove bad_dma_ops to fix build fail Mark Brown <broonie@kernel.org> - 2016-06-13 14:00 +0200
            Re: [PATCH] dma: remove bad_dma_ops to fix build fail Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-13 14:20 +0200
    Re: [PATCH] dma: remove bad_dma_ops to fix build fail Christoph Hellwig <hch@lst.de> - 2016-06-13 10:00 +0200

csiph-web