Groups > linux.kernel > #1420284

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

From	Dong Aisheng <dongas86@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3
Date	2016-06-12 17:00 +0200
Message-ID	<rJf1L-1vg-11@gated-at.bofh.it> (permalink)
References	<rI2SZ-3kN-9@gated-at.bofh.it> <rI2SZ-3kN-11@gated-at.bofh.it> <rJbUd-854-23@gated-at.bofh.it> <rJcwW-7R-15@gated-at.bofh.it> <rJdMm-Nl-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 12, 2016 at 9:29 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Sun, Jun 12, 2016 at 08:13:03PM +0800, Dong Aisheng wrote:
>> I understand your point.
>> How about using power_bit and powerup_set?
>> * @power_bit:   pll power bit offset
>
> I'm fine with the name, but the comment should be fixed, since we are
> actually using it as a bit mask instead of offset.
>

Yes, i can change to:
* @power_bit:   pll power bit mask
* @powerup_set: set power_bit to power up the PLL

Regards
Dong Aisheng

> Shawn
>
>> * @powerup_set: set power_bit to power up the PLL
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Shawn Guo <shawnguo@kernel.org> - 2016-06-12 13:40 +0200
  Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Dong Aisheng <dongas86@gmail.com> - 2016-06-12 14:00 +0200
  Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Dong Aisheng <dongas86@gmail.com> - 2016-06-12 14:20 +0200
    Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Shawn Guo <shawnguo@kernel.org> - 2016-06-12 15:40 +0200
      Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3 Dong Aisheng <dongas86@gmail.com> - 2016-06-12 17:00 +0200

csiph-web