Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420238
| From | Peter Chen <hzpeterchen@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core |
| Date | 2016-06-12 13:30 +0200 |
| Message-ID | <rJbKy-825-25@gated-at.bofh.it> (permalink) |
| References | <rIumd-4YI-3@gated-at.bofh.it> <rIumf-4YI-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 10, 2016 at 04:07:17PM +0300, Roger Quadros wrote:
> index dca7856..03f7204 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -59,5 +59,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/
> obj-$(CONFIG_USB_GADGET) += gadget/
>
> obj-$(CONFIG_USB_COMMON) += common/
> +obj-$(CONFIG_USB_OTG_CORE) += common/
I don't think you need to make above change, why you do it?
> +
> +/**
> + * usb_otg_get_data() - get usb_otg data structa
%s/structa/structure
> +
> +/**
> + * usb_otg_kick_fsm() - Kick the OTG state machine
> + * @otg_dev: OTG controller device
> + *
> + * Used by USB host/gadget stack to sync OTG related
> + * events to the OTG state machine.
> + * e.g. change in host_bus->b_hnp_enable, gadget->b_hnp_enable
> + *
> + * Return: 0 on success, error value otherwise.
> + */
> +int usb_otg_kick_fsm(struct device *otg_dev)
> +{
> + struct usb_otg *otg;
> +
> + mutex_lock(&otg_list_mutex);
> + otg = usb_otg_get_data(otg_dev);
> + mutex_unlock(&otg_list_mutex);
> + if (!otg) {
> + dev_dbg(otg_dev, "otg: %s: invalid otg device\n",
> + __func__);
> + return -ENODEV;
> + }
> +
> + usb_otg_sync_inputs(otg);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(usb_otg_kick_fsm);
Do you have any users for this API? If no, please delete it in this
version.
> +
> +/**
> + * usb_otg_register_hcd() - Register the host controller to OTG core
> + * @hcd: host controller
> + * @irqnum: interrupt number
> + * @irqflags: interrupt flags
> + * @ops: HCD ops to interface with the HCD
> + *
> + * This is used by the USB Host stack to register the host controller
> + * to the OTG core. Host controller must not be started by the
> + * caller as it is left upto the OTG state machine to do so.
%s/upto/up to
> +
> +/**
> + * usb_otg_register_gadget() - Register the gadget controller to OTG core
> + * @gadget: gadget controller instance
> + * @ops: gadget interface ops
> + *
> + * This is used by the USB gadget stack to register the gadget controller
> + * to the OTG core. Gadget controller must not be started by the
> + * caller as it is left upto the OTG state machine to do so.
> + *
%s/upto/up to
--
Best Regards,
Peter Chen
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v10 00/14] USB OTG/dual-role framework Roger Quadros <rogerq@ti.com> - 2016-06-10 15:10 +0200
[PATCH v10 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-10 15:10 +0200
Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-12 13:30 +0200
Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-13 09:50 +0200
[PATCH v11 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-13 10:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-20 09:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-20 12:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-20 14:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-20 14:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-20 14:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 08:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 09:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 10:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 10:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 14:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 14:40 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 15:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 16:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-22 05:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-22 09:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-22 09:40 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-22 10:10 +0200
RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-06-23 09:50 +0200
RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-06-21 04:40 +0200
RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 09:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-20 14:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-20 14:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 08:40 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 09:30 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 11:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 12:10 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Tony Lindgren <tony@atomide.com> - 2016-06-21 13:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-21 13:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-21 18:50 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-22 09:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Peter Chen <hzpeterchen@gmail.com> - 2016-06-22 10:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-22 10:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-22 10:00 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Felipe Balbi <balbi@kernel.org> - 2016-06-22 10:20 +0200
Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Roger Quadros <rogerq@ti.com> - 2016-06-22 10:40 +0200
RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-06-23 09:50 +0200
[PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros <rogerq@ti.com> - 2016-06-10 15:20 +0200
[PATCH v10 10/14] usb: otg: add hcd companion support Roger Quadros <rogerq@ti.com> - 2016-06-10 15:20 +0200
[PATCH v10 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros <rogerq@ti.com> - 2016-06-10 15:20 +0200
Re: [PATCH v10 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros <rogerq@ti.com> - 2016-06-13 10:20 +0200
[PATCH v11 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros <rogerq@ti.com> - 2016-06-13 10:30 +0200
RE: [PATCH v10 09/14] usb: of: add an API to get OTG device from USB controller node Jun Li <jun.li@nxp.com> - 2016-06-13 10:30 +0200
Re: [PATCH v10 00/14] USB OTG/dual-role framework Peter Chen <hzpeterchen@gmail.com> - 2016-06-14 04:30 +0200
Re: [PATCH v10 00/14] USB OTG/dual-role framework Roger Quadros <rogerq@ti.com> - 2016-06-14 10:20 +0200
Re: [PATCH v10 00/14] USB OTG/dual-role framework Roger Quadros <rogerq@ti.com> - 2016-06-16 13:10 +0200
Re: [PATCH v10 00/14] USB OTG/dual-role framework Felipe Balbi <balbi@kernel.org> - 2016-06-17 09:20 +0200
Re: [PATCH v10 00/14] USB OTG/dual-role framework Roger Quadros <rogerq@ti.com> - 2016-06-17 09:40 +0200
csiph-web