Groups > linux.kernel > #1420218

Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt to be level-triggered

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt to be level-triggered
Date	2016-06-12 12:20 +0200
Message-ID	<rJaEO-7pO-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <rIfwT-3u0-45@gated-at.bofh.it> <rIpcS-1FF-25@gated-at.bofh.it> <rIyzv-7xq-21@gated-at.bofh.it> <rINId-1ny-15@gated-at.bofh.it> <rJaEO-7pO-7@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On Sat, 11 Jun 2016 13:02:44 +0100
Ben Dooks <bjdooks@googlemail.com> wrote:

> out of interest, do you have a list of what the problems are?

The trigger configuration for per-cpu interrupts silently fails
(because set_irq_type cannot deal with them). Which means we're relying
on whatever configuration the firmware has left in there. Also, the
kernel defaults to considering the interrupt as edge.

What saves most platforms so far is that they are using a GIC:
1) Most GIC implementations have their PPI configuration as RO, which
   means that we can't get it wrong.
2) If using a fasteoi handler, there is no significant difference in the
   flow between edge and level (we're relying on the HW dealing with it,
   so (1) is critical).

If your GIC allows PPI configuration to be written and firmware gets it
wrong, you'll miss interrupts. If you don't have a GIC, all bets are
off.

I've queued a number of patches to solve this, which I hope to send to
tglx tomorrow (after looking at this weekend test run).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.

Thread

[PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt to be level-triggered Marc Zyngier <marc.zyngier@arm.com> - 2016-06-06 20:00 +0200
  Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt  to be level-triggered David Daney <ddaney.cavm@gmail.com> - 2016-06-09 23:20 +0200
    Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU  interrupt to be level-triggered Marc Zyngier <marc.zyngier@arm.com> - 2016-06-10 09:40 +0200
      Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt  to be level-triggered David Daney <ddaney.cavm@gmail.com> - 2016-06-10 19:40 +0200
        Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU  interrupt to be level-triggered Marc Zyngier <marc.zyngier@arm.com> - 2016-06-11 11:50 +0200
          Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU  interrupt to be level-triggered Marc Zyngier <marc.zyngier@arm.com> - 2016-06-12 12:20 +0200
      Re: [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU  interrupt to be level-triggered Duc Dang <dhdang@apm.com> - 2016-06-11 00:00 +0200

csiph-web