Groups > linux.kernel > #1422023

Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs
Date	2016-06-14 17:50 +0200
Message-ID	<rJYLf-6MM-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <rIGQp-5BE-5@gated-at.bofh.it> <rIGQp-5BE-1@gated-at.bofh.it> <rIT1f-4Lm-17@gated-at.bofh.it> <rJ2nT-26O-1@gated-at.bofh.it> <rJYLf-6MM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 14/06/16 09:45 AM, Allen Hubbe wrote:
> 
> Feel free to disregard my suggestion above.  I hope my comment has not cost you too much time.
> 
> The way you have written it already, and used it in the self-test script is much more concise.
> 
>>> + * root@self# echo > $DBG_DIR/link
> 
> Acked-by: Allen.Hubbe@emc.com
> 
> 
> 
> Eventually, I think it would be useful to let ntb_tool enable and disable the link.  In that case, it might also be useful in a test script to wait for link down, not just link up.
> 
> What about this:
> 
> # Wait for the link to be up or down
> root@self# echo 1 > $DBG_DIR/link
> root@self# echo 0 > $DBG_DIR/link
> 
> It need not be a part of this patch, but eventually:
> 
> # Enable or disable the link
> root@self# echo 1 > $DBG_DIR/link_ctrl
> root@self# echo 0 > $DBG_DIR/link_ctrl
> 
> # Reading the link_ctrl file can also give the link status
> root@self# cat $DBG_DIR/link_ctrl
> 
> Finally, I wonder if the file called "link" in this patch should be called "link_wait" or similar, so its purpose is obviously not for enabling and disabling the link.
> 

Actually I've already implemented something similar to your original
suggestion. I'll be submitting a v2 of this set shortly.

Logan

Thread

Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs Allen Hubbe <allenbh@gmail.com> - 2016-06-12 03:30 +0200
  Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs Logan Gunthorpe <logang@deltatee.com> - 2016-06-14 17:50 +0200
    RE: [PATCH 6/8] ntb_tool: Add link status file to debugfs "Allen Hubbe" <Allen.Hubbe@emc.com> - 2016-06-14 18:00 +0200
  RE: [PATCH 6/8] ntb_tool: Add link status file to debugfs "Allen Hubbe" <Allen.Hubbe@emc.com> - 2016-06-14 17:50 +0200

csiph-web