Groups > linux.kernel > #1421966

Re: [PATCH 02/27] mm, vmscan: Move lru_lock to the node

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/27] mm, vmscan: Move lru_lock to the node
Date	2016-06-14 16:50 +0200
Message-ID	<rJXPc-66e-17@gated-at.bofh.it> (permalink)
References	<rIcyZ-1vR-3@gated-at.bofh.it> <rIcyZ-1vR-13@gated-at.bofh.it> <rIxDs-6XO-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 10, 2016 at 06:39:26PM +0200, Vlastimil Babka wrote:
> > @@ -5944,10 +5944,10 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat)
> >  		zone->min_slab_pages = (freesize * sysctl_min_slab_ratio) / 100;
> >  #endif
> >  		zone->name = zone_names[j];
> > +		zone->zone_pgdat = pgdat;
> >  		spin_lock_init(&zone->lock);
> > -		spin_lock_init(&zone->lru_lock);
> > +		spin_lock_init(zone_lru_lock(zone));
> 
> This means the same lock will be inited MAX_NR_ZONES times. Peterz told
> me it's valid but weird. Probably better to do it just once, in case
> lockdep/lock debugging gains some checks for that?
> 

Good point and it's an easy fix.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 02/27] mm, vmscan: Move lru_lock to the node Mel Gorman <mgorman@techsingularity.net> - 2016-06-14 16:50 +0200

csiph-web