Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1421729
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/5] gpio: of: move chip->of_gpio_n_cells checking to of_gpiochip_add() |
| Date | 2016-06-14 12:10 +0200 |
| Message-ID | <rJTse-3r2-13@gated-at.bofh.it> (permalink) |
| References | <rJTsd-3r2-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Do this sanity check only once when the gpio_chip is added rather than every time gpio-hog is handled. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/gpio/gpiolib-of.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 27b1729..a5a5bc7 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -156,7 +156,7 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, if (ret) return ERR_PTR(ret); - if (tmp > MAX_PHANDLE_ARGS || tmp != chip->of_gpio_n_cells) + if (tmp != chip->of_gpio_n_cells) return ERR_PTR(-EINVAL); gpiospec.np = chip_np; @@ -487,6 +487,9 @@ int of_gpiochip_add(struct gpio_chip *chip) chip->of_xlate = of_gpio_simple_xlate; } + if (chip->of_gpio_n_cells > MAX_PHANDLE_ARGS) + return -EINVAL; + status = of_gpiochip_add_pin_range(chip); if (status) return status; -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 3/5] gpio: of: move chip->of_gpio_n_cells checking to of_gpiochip_add() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-14 12:10 +0200 Re: [PATCH 3/5] gpio: of: move chip->of_gpio_n_cells checking to of_gpiochip_add() Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 09:40 +0200
csiph-web