[PATCH 5/7] ubi: Check whether the Fastmap anchor matches the super block

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	[PATCH 5/7] ubi: Check whether the Fastmap anchor matches the super block
Date	2016-06-14 10:20 +0200
Message-ID	<rJRJL-2cK-3@gated-at.bofh.it> (permalink)
References	<rJRJL-2cK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This helps to detect cases where an user copies an UBI image to
another target with different bad blocks.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/mtd/ubi/fastmap.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 12bdb09..b66cb3e 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -975,6 +975,13 @@ int ubi_scan_fastmap(struct ubi_device *ubi, struct ubi_attach_info *ai,
 			goto free_hdr;
 		}
 
+		if (i == 0 && pnum != fm_anchor) {
+			ubi_err(ubi, "Fastmap anchor PEB mismatch: PEB: %i vs. %i",
+				pnum, fm_anchor);
+			ret = UBI_BAD_FASTMAP;
+			goto free_hdr;
+		}
+
 		ret = ubi_io_read_ec_hdr(ubi, pnum, ech, 0);
 		if (ret && ret != UBI_IO_BITFLIPS) {
 			ubi_err(ubi, "unable to read fastmap block# %i EC (PEB: %i)",
-- 
2.7.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 5/7] ubi: Check whether the Fastmap anchor matches the super block Richard Weinberger <richard@nod.at> - 2016-06-14 10:20 +0200

csiph-web