Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421301

Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue

Show all headers | View raw

On 06/13/2016 12:29 PM, Robert Richter wrote:
> Heiko,
> 
> On 09.06.16 11:00:56, Heiko Carstens wrote:
>> However I'm wondering if we shouldn't simply remove at least the s390
>> specific hwswampler code from the oprofile module. This would still leave
>> the common code timer based sampling mode for oprofile working on s390.
>>
>> It looks like the oprofile user space utility nowadays (since 2012) uses
>> the kernel perf interface instead of the oprofile interface anyway, if
>> present. So the oprofile module itself doesn't seem to have too many users
>> left.
>>
>> Any opinions?
> 
> yes, the kernel driver is not necessary for oprofile userland for a
> while now. There is no ongoing development any longer, most patches
> are due to changes in the kernel apis.
> 
> So if there is code that needs a larger rework due to other kernel
> changes and there is no user anymore, I am fine with removing the code
> instead of reworking it. I still would just keep existing code as long
> as we can keep it unchanged (some like the lightwight of oprofile,
> esp. in the embedded space). If there is a user of the code, a
> Tested-by would be good for new code changes.
> 
> If there are users of the hwswampler, speak up now. Else, let's just
> remove it.
> 
> -Robert
> 

Hi,

As Robert mentioned the user-space oprofile code that would have used the oprofile device driver was removed around August 2014 in preparation for oprofile-1.0. The operf command which uses the kernel perf infrastructure and does not need for the oprofile kernel driver has been in oprofile since August of 2012.  For some architectures it would make sense to simplify things by eliminate the oprofile kernel driver.

-Will Cohen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue Robert Richter <rric@kernel.org> - 2016-06-13 18:30 +0200
  Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue William Cohen <wcohen@redhat.com> - 2016-06-13 22:50 +0200
  Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-06-14 07:40 +0200
    Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue Robert Richter <rric@kernel.org> - 2016-06-14 15:30 +0200
      Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue Hendrik Brueckner <brueckner@linux.vnet.ibm.com> - 2016-06-17 11:10 +0200

csiph-web