Re: [PATCH 1/2] liblockdep: Fix compile errors

From	Sasha Levin <sasha.levin@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] liblockdep: Fix compile errors
Date	2016-06-13 22:40 +0200
Message-ID	<rJGOl-2R5-11@gated-at.bofh.it> (permalink)
References	<rI8lI-6YM-3@gated-at.bofh.it> <rI8lJ-6YM-41@gated-at.bofh.it> <rIIfv-6jL-5@gated-at.bofh.it> <rIMCu-KC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/11/2016 04:36 AM, Vishal Thanki wrote:
> On Sat, Jun 11, 2016 at 5:53 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> On 06/09/2016 09:34 AM, Vishal Thanki wrote:
>>> dfaaf3fa0: (Use __jhash_mix() for iterate_chain_key())
>>> Fixed by adding jhash.h with minimal stuff required
>>
>> Can we, instead of copying it over, include jhash.h directly
>> (just like we do for hash.h)?
>>
>>
> That was the first thing I tried, but then it caused more compilation
> errors due to nested header dependencies and I ended up taking the
> only required stuff. Better ideas are welcome.

I just gave it a quick go and didn't see anything beyond needing to take
in linux/unaligned/packed_struct.h as well. What sort of errors did you
hit?


Thanks,
Sasha

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] liblockdep: Fix compile errors Sasha Levin <sasha.levin@oracle.com> - 2016-06-13 22:40 +0200
  Re: [PATCH 1/2] liblockdep: Fix compile errors Vishal Thanki <vishalthanki@gmail.com> - 2016-06-14 12:30 +0200

csiph-web