Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger
Date	2016-06-13 21:10 +0200
Message-ID	<rJFph-22H-75@gated-at.bofh.it> (permalink)
References	(2 earlier) <ruZpT-7Yn-1@gated-at.bofh.it> <rxVg7-2MC-13@gated-at.bofh.it> <rAqpr-53G-5@gated-at.bofh.it> <rI7zk-6pj-11@gated-at.bofh.it> <rJBYm-86X-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> > João, that means you should send a patch to add the ::rfkill suffix.
> >
> 
> IMO "airplane" (or maybe "airplane-mode") is a better suffix, as it
> reflects the label on the machine's chassis. I'll name it
> "asus-wireless::airplane" and send this through platform-drivers-x86,
> as this is now contained in the platform-drivers-x86 subsystem. Thanks
> Johannes for your patience and help designing and reviewing the rfkill
> changes, even if not all of them made it through in the end. And
> thanks everyone else involved for the feedback.

Actually, I'd do '::rfkill', for consistency with other places in
/sys.

/sys/devices/platform/thinkpad_acpi/rfkill/rfkill1/name
/sys/class/rfkill
/sys/module/rfkill

Thanks for patience,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger João Paulo Rechi Vita <jprvita@gmail.com> - 2016-06-13 17:30 +0200
  Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Pavel Machek <pavel@ucw.cz> - 2016-06-13 21:10 +0200
    Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger João Paulo Rechi Vita <jprvita@gmail.com> - 2016-06-13 22:10 +0200
      Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Pavel Machek <pavel@ucw.cz> - 2016-06-13 23:10 +0200
        Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger João Paulo Rechi Vita <jprvita@gmail.com> - 2016-06-13 23:20 +0200
          Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Pavel Machek <pavel@ucw.cz> - 2016-06-13 23:30 +0200
            Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED  trigger Johannes Berg <johannes@sipsolutions.net> - 2016-06-21 11:40 +0200

csiph-web