Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L

Path	csiph.com!goblin3!goblin.stu.neva.ru!sewer!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Nick Dyer <nick.dyer@itdev.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
Date	Mon, 13 Jun 2016 18:50:02 +0200
Message-ID	<rJDdM-ph-11@gated-at.bofh.it> (permalink)
References	<rFhvc-2p3-23@gated-at.bofh.it> <rFiUi-3wl-25@gated-at.bofh.it> <rFCzD-7xa-13@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
X-Outgoing-Spam-Status	No, score=-1.5
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - zencphosting06.zen.co.uk
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - itdev.co.uk
X-Get-Message-Sender-Via	zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk
X-Authenticated-Sender	zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Benson Leung <bleung@chromium.org>, Alan Bowens <Alan.Bowens@atmel.com>, Javier Martinez Canillas <javier@osg.samsung.com>, Chris Healy <cphealy@gmail.com>, Henrik Rydberg <rydberg@bitmath.org>, Andrew Duggan <aduggan@synaptics.com>, James Chen <james.chen@emc.com.tw>, Dudley Du <dudl@cypress.com>, Andrew de los Reyes <adlr@chromium.org>, sheckylin@chromium.org, Peter Hutterer <peter.hutterer@who-t.net>, Florian Echtler <floe@butterbrot.org>, mchehab@osg.samsung.com
X-Original-Date	Mon, 13 Jun 2016 17:40:52 +0100
X-Original-Message-ID	<65c7873a-439d-fc84-50b4-f63a7934e9db@itdev.co.uk>
X-Original-References	<1464799192-28034-1-git-send-email-nick.dyer@itdev.co.uk> <20160601181700.GD4114@dtor-ws> <d8c40054-359c-5e21-6c1f-be38fd2368db@itdev.co.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1421049

Show key headers only | View raw

On 02/06/2016 16:14, Nick Dyer wrote:
> On 01/06/2016 19:17, Dmitry Torokhov wrote:
>> On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote:
>>> This is a series of patches to add diagnostic data support to the Atmel
>>> maXTouch driver. It's a rewrite of the previous implementation which output via
>>> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver.
>>
>> I do not have any objections other than some nits form the input side;
>> majority of the review should come from V4L2 side here...
> 
> Thanks for the review. I've hopefully fixed the issues you raised and
> pushed it to
>     https://github.com/ndyer/linux/commits/diagnostic-v4l-20160602
> 
> I will wait for the V4L2 folks to comment before posting a [PATCH v4]

Hi Hans-

I've done a bit of further work on this now, so unless you have any
conerns, I'm going to post an update to the patch set in the next couple of
days.

cheers

Nick

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic  data via V4L Nick Dyer <nick.dyer@itdev.co.uk> - 2016-06-13 18:50 +0200

csiph-web