Re: Using irq-crossbar.c

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: Using irq-crossbar.c
Date	2016-06-13 18:30 +0200
Message-ID	<rJCUq-iw-11@gated-at.bofh.it> (permalink)
References	<rIwHo-6kc-21@gated-at.bofh.it> <rIxaq-6KH-43@gated-at.bofh.it> <rIArD-AY-5@gated-at.bofh.it> <rINRT-1qU-3@gated-at.bofh.it> <rJBOF-82T-15@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On 13/06/16 16:15, Sebastian Frias wrote:

>>> The base file he was referring to is:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/tango4-common.dtsi
>>
>> I know which file that is, it is mentioned in the diff. I was merely
>> trying to point out the glaring mistakes that could be enough for a
>> interrupt controller hierarchy to be completely non-functional:
>>
>> - Your crossbar doesn't have a #interrupt-cells property. How do you
>>   expect the interrupt specifiers to be interpreted?
> 
> Thanks for the pointer, actually, after adding "#interrupt-cells =
> <3>;" I can see the driver getting requests for domain maps and
> xlates :-)

OK, we're getting somewhere.

>> - You've changed the default interrupt controller to be your crossbar.
>>   Which means that all the sub-nodes are inheriting it. Have you
>>   checked that this was valid for all of these nodes?
> 
> What do you mean with "valid for all these nodes"? All HW irq lines go to the crossbar.

All the interrupt lines *in the system*? Or just those that are in the
nodes below the "soc" section?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Using irq-crossbar.c Sebastian Frias <sf84@laposte.net> - 2016-06-13 17:20 +0200
  Re: Using irq-crossbar.c Marc Zyngier <marc.zyngier@arm.com> - 2016-06-13 18:30 +0200

csiph-web