Groups > linux.kernel > #1420832

Re: [patch] IB/rxe: fix error code in rxe_srq_from_init()

From	Leon Romanovsky <leon@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [patch] IB/rxe: fix error code in rxe_srq_from_init()
Date	2016-06-13 15:30 +0200
Message-ID	<rJA6e-6PL-37@gated-at.bofh.it> (permalink)
References	<rJu0O-2EM-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 13, 2016 at 09:53:41AM +0300, Dan Carpenter wrote:
> If copy_to_user() fails then it returns the number of bytes not copied.
> It would be between 1-4 here.  Later the callers dereference it leading
> to an Oops.
> 
> It was sort of hard to fix this without making the code confusing so I
> did a little cleanup.
> 
> Fixes: 443c15d23220 ('IB/rxe: Shared Receive Queue (SRQ) manipulation functions')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan,
I applied it on topic/rxe.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] IB/rxe: fix error code in rxe_srq_from_init() Dan Carpenter <dan.carpenter@oracle.com> - 2016-06-13 09:00 +0200
  Re: [patch] IB/rxe: fix error code in rxe_srq_from_init() Moni Shoua <monis@mellanox.com> - 2016-06-13 09:30 +0200
  Re: [patch] IB/rxe: fix error code in rxe_srq_from_init() Leon Romanovsky <leon@kernel.org> - 2016-06-13 15:30 +0200

csiph-web