Groups > linux.kernel > #1419424

Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024

From	Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024
Date	2016-06-10 15:40 +0200
Message-ID	<rIuPg-58O-17@gated-at.bofh.it> (permalink)
References	<rIrRo-3lN-9@gated-at.bofh.it> <rIrRo-3lN-21@gated-at.bofh.it> <rIuFz-55o-1@gated-at.bofh.it> <rIuFA-55o-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Laxman,

On Fri, Jun 10, 2016 at 9:13 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
> On Friday 10 June 2016 06:50 PM, Javier Martinez Canillas wrote:
>>
>> Hello Laxman,
>>
>> On Fri, Jun 10, 2016 at 6:12 AM, Laxman Dewangan <ldewangan@nvidia.com>
>> wrote:
>>>
>>> MAXIM MAX77620 is the power management IC with multiple DCDC/LDO(
>>> regulators, RTC, GPIOs, Watchdog, 32KHz clock source etc.
>>>
>>> Add support for controlling the 32KHz clock source via clock
>>> framework.
>>>
>>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>>> ---
>>
>> It looks very similar to the max77686 and max77802 drivers (with only
>> the difference in number of clock outputs), can you use the helpers in
>> drivers/clk/clk-max-gen.c ?
>
>
> I have explored that option.
>
> The bit location for clock bit on register are same in case of max77686 and
> max77802 but it is different for the max77620.
>

Ok, I see.

> So until I change it too generic, it will not be possible.
> Also if it is require then what about all max77686/max77802 and max77620 in
> single file, the way we did for RTC.
> We dont need 4 files for the similar driver then.
>

Indeed, probably is better to have a single driver to handle all these
IP variants since they seem to be quite similar.

Best regards,
Javier

Thread

[PATCH 1/2] clk: max77620: Add DT binding doc for MAX77620 clock Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-10 12:30 +0200
  [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-10 12:30 +0200
    Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Javier Martinez Canillas <javier@dowhile0.org> - 2016-06-10 15:30 +0200
      Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-10 15:30 +0200
        Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Javier Martinez Canillas <javier@dowhile0.org> - 2016-06-10 15:40 +0200
          Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-10 15:50 +0200
            Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-10 16:20 +0200
  Re: [PATCH 1/2] clk: max77620: Add DT binding doc for MAX77620 clock Javier Martinez Canillas <javier@dowhile0.org> - 2016-06-10 15:30 +0200

csiph-web