Groups > linux.kernel > #1419308

Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card
Date	2016-06-10 14:00 +0200
Message-ID	<rItgu-45e-9@gated-at.bofh.it> (permalink)
References	(4 earlier) <rI1WW-2L4-15@gated-at.bofh.it> <rI60x-5xV-7@gated-at.bofh.it> <rIb9T-pw-3@gated-at.bofh.it> <rIeAO-2Pc-15@gated-at.bofh.it> <rIibn-5uh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Yinghai Lu <yinghai@kernel.org> wrote:

> On 6/9/16, Lukas Wunner <lukas@wunner.de> wrote:
> >
> > Well, the PCI core would also scan such a bus twice AFAICS.
> > And the performance penalty of scanning it twice seems negligible.
> > Early quirks can prevent double execution by setting QFLAG_APPLY_ONCE.
> > (Three quirks have set that flag already.)
> >
> > So I think this shouldn't be a concern.
> 
> I don't know. I would like see sth like following, and that is simple enough.
> 
> Index: linux-2.6/arch/x86/kernel/early-quirks.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/early-quirks.c
> +++ linux-2.6/arch/x86/kernel/early-quirks.c
> @@ -755,10 +755,16 @@ static int __init check_dev_quirk(int nu
>         return 0;
>  }
> 
> +static unsigned char __initdata scanned[256];
>  static void __init early_pci_scan_bus(int bus)
>  {
>         int slot, func;
> 
> +       if (scanned[bus])
> +               return;
> +
> +       scanned[bus] = 1;
> +
>         /* Poor man's PCI discovery */
>         for (slot = 0; slot < 32; slot++)
>                 for (func = 0; func < 8; func++) {

Ok, I removed the fix from tip:x86/urgent from the time being - could you guys 
please send a full version once a final approach is agreed upon?

Thanks,

	Ingo

Thread

[tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort  card tip-bot for Lukas Wunner <tipbot@zytor.com> - 2016-06-08 16:30 +0200
  Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Yinghai Lu <yinghai@kernel.org> - 2016-06-08 21:00 +0200
    Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Lukas Wunner <lukas@wunner.de> - 2016-06-08 22:10 +0200
      Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Ingo Molnar <mingo@kernel.org> - 2016-06-09 08:50 +0200
        Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Lukas Wunner <lukas@wunner.de> - 2016-06-09 13:10 +0200
          Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Yinghai Lu <yinghai@kernel.org> - 2016-06-09 18:40 +0200
            Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Lukas Wunner <lukas@wunner.de> - 2016-06-09 22:20 +0200
              Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Yinghai Lu <yinghai@kernel.org> - 2016-06-10 02:10 +0200
                Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Ingo Molnar <mingo@kernel.org> - 2016-06-10 14:00 +0200
                Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Lukas Wunner <lukas@wunner.de> - 2016-06-10 14:20 +0200
                Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Ingo Molnar <mingo@kernel.org> - 2016-06-10 15:10 +0200
                Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Lukas Wunner <lukas@wunner.de> - 2016-06-10 16:00 +0200
                Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple  AirPort card Bjorn Helgaas <helgaas@kernel.org> - 2016-06-10 22:10 +0200

csiph-web