Groups > linux.kernel > #1419152

[PATCH] mm, slaub: Add __GFP_ATOMIC to the GFP reclaim mask

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	[PATCH] mm, slaub: Add __GFP_ATOMIC to the GFP reclaim mask
Date	Fri, 10 Jun 2016 11:40:02 +0200
Message-ID	<rIr50-2Pg-17@gated-at.bofh.it> (permalink)
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-15
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Marcin Wojtas <mw@semihalf.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>
X-Original-Date	Fri, 10 Jun 2016 10:38:32 +0100
X-Original-Message-ID	<20160610093832.GK2527@techsingularity.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1419152

Show key headers only | View raw

Commit d0164adc89f6 ("mm, page_alloc: distinguish between being unable to
sleep, unwilling to sleep and avoiding waking kswapd") modified __GFP_WAIT
to explicitly identify the difference between atomic callers and those that
were unwilling to sleep. Later the definition was removed entirely.

The GFP_RECLAIM_MASK is the set of flags that affect watermark checking
and reclaim behaviour but __GFP_ATOMIC was never added. Without it, atomic
users of the slab allocator strip the __GFP_ATOMIC flag and cannot access
the page allocator atomic reserves.  This patch addresses the problem.

The user-visible impact depends on the workload but potentially atomic
allocations unnecessarily fail without this path.

Cc: <stable@vger.kernel.org> # 4.4+
Reported-by: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/internal.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/internal.h b/mm/internal.h
index a37e5b6f9d25..2524ec880e24 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -24,7 +24,8 @@
  */
 #define GFP_RECLAIM_MASK (__GFP_RECLAIM|__GFP_HIGH|__GFP_IO|__GFP_FS|\
 			__GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL|\
-			__GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC)
+			__GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC|\
+			__GFP_ATOMIC)
 
 /* The GFP flags allowed during early boot */
 #define GFP_BOOT_MASK (__GFP_BITS_MASK & ~(__GFP_RECLAIM|__GFP_IO|__GFP_FS))

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, slaub: Add __GFP_ATOMIC to the GFP reclaim mask Mel Gorman <mgorman@techsingularity.net> - 2016-06-10 11:40 +0200
  Re: [PATCH] mm, slaub: Add __GFP_ATOMIC to the GFP reclaim mask Vlastimil Babka <vbabka@suse.cz> - 2016-06-10 12:20 +0200

csiph-web