Groups > linux.kernel > #1419097

Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver
Date	2016-06-10 09:40 +0200
Message-ID	<rIpcS-1FF-17@gated-at.bofh.it> (permalink)
References	<rFiAV-3aE-3@gated-at.bofh.it> <rFiAV-3aE-13@gated-at.bofh.it> <rFy2Z-4Jw-21@gated-at.bofh.it> <rIfnc-3pv-33@gated-at.bofh.it> <rIiEp-5Fe-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Mark,

On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote:
> > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
> > > > +{
> > > > +	struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
> 
> > > > +	/* Enable the whole hardware block */
> > > > +	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > > > +		     SUN4I_I2S_CTRL_GL_EN);
> 
> > > Runtime PM?  It also seems like this is something that ought to be
> > > covered in the suspend and resume callbacks.
> 
> > runtime_pm is supported, and uses the regmap cache to keep those
> > changes.
> 
> No, my point is that I'd expect to see the block powered off on suspend.

It is. The bus clock is disabled, which also puts the IP in reset.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-01 20:00 +0200
  Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Code Kipper <codekipper@gmail.com> - 2016-06-02 10:10 +0200
    Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-09 23:10 +0200
  Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Mark Brown <broonie@kernel.org> - 2016-06-02 12:30 +0200
    Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-09 23:10 +0200
      Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Mark Brown <broonie@kernel.org> - 2016-06-10 02:40 +0200
        Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-10 09:40 +0200

csiph-web