Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419062

Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT ids through ACPI

Show all headers | View raw

On Thu, Jun 09, 2016 at 04:06:03PM +0300, Crestez Dan Leonard wrote:
> When devices are instatiated through devicetree the i2c_client->name is
> set to the compatible string with company name stripped out. This is
> then matched to the i2c_device_id table to pass the device_id to the
> probe function. This id parameter is used by some device drivers to
> differentiate between model numbers.
> 
> When using ACPI this id parameter is NULL and the driver usually needs
> to do ACPI-specific differentiation.
> 
> This patch attempts to find a valid i2c_device_id when using ACPI with
> DT-like compatible strings.

So I don't really understand why it would be good idea to pass
i2c_device_id for devices which are matched against their ACPI/DT
tables. Apparently DT is already doing that so maybe there is some
reason.

Anyway, why not fill in the device name when it is first enumerated
if it uses DT compatible property? Just like DT does.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT ids through ACPI Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-09 15:10 +0200
  Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT  ids through ACPI Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-10 08:40 +0200
    Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT  ids through ACPI Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-10 18:00 +0200
  Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT  ids through ACPI Wolfram Sang <wsa@the-dreams.de> - 2016-06-10 09:10 +0200
    Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT  ids through ACPI Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-06-10 14:10 +0200
      Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT  ids through ACPI Wolfram Sang <wsa@the-dreams.de> - 2016-06-10 15:10 +0200

csiph-web