Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419056

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

From Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] max8903: adds support for initiation via device tree.
Date 2016-06-10 08:20 +0200
Message-ID <rInXr-10i-7@gated-at.bofh.it> (permalink)
References <rFuC5-2sz-15@gated-at.bofh.it> <rFuC6-2sz-41@gated-at.bofh.it> <rI5xw-579-29@gated-at.bofh.it> <rInkK-vX-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 06/10/2016 07:35 AM, Chris Lapa wrote:
> Hi Krzysztof,
> 
> Thanks for the review. I'm working on those changes now.
> 
> However just so I know for the future. Why no error checking on
> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
> looks like NULL isn't caught anywhere else.

Error checking is necessary. Just do not print the error message. The
kernel core will print one with full back trace.

if (charger == NULL)
	return -ENOMEM;


Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] max8903: Add device tree support and logic fixup chris@lapa.com.au - 2016-06-02 08:50 +0200
  [PATCH 1/2] max8903: adds support for initiation via device tree. chris@lapa.com.au - 2016-06-02 08:50 +0200
    Re: [PATCH 1/2] max8903: adds support for initiation via device tree. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-09 12:40 +0200
      Re: [PATCH 1/2] max8903: adds support for initiation via device tree. Chris Lapa <chris@lapa.com.au> - 2016-06-10 07:40 +0200
        Re: [PATCH 1/2] max8903: adds support for initiation via device tree. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-10 08:20 +0200
          Re: [PATCH 1/2] max8903: adds support for initiation via device tree. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-10 12:30 +0200

csiph-web