Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table
Date	2016-06-10 03:30 +0200
Message-ID	<rIjqO-6ed-27@gated-at.bofh.it> (permalink)
References	<rEWTM-6iC-39@gated-at.bofh.it> <rEWTM-6iC-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, May 31, 2016 at 01:45:00PM -0500, Andrew F. Davis wrote:
> Currently for each device with a unique register map we have a named
> array that we then merge into a multidimensional array. Skip this
> middle step and apply the register arrays directly to the multi-array.

I applied the first two patches, but the third (this one) does not
compile for me:

  CC [M]  drivers/power/bq27xxx_battery.o
drivers/power/bq27xxx_battery.c:108:2: warning: braces around scalar initializer
  [BQ27000] = {
  ^
drivers/power/bq27xxx_battery.c:108:2: note: (near initialization for ‘bq27xxx_regs[1]’)
drivers/power/bq27xxx_battery.c:109:4: error: array index in non-array initializer
   [BQ27XXX_REG_CTRL] = 0x00,
    ^
drivers/power/bq27xxx_battery.c:109:4: note: (near initialization for ‘bq27xxx_regs[1]’)
drivers/power/bq27xxx_battery.c:110:4: error: array index in non-array initializer
   [BQ27XXX_REG_TEMP] = 0x06,
    ^
...

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table "Andrew F. Davis" <afd@ti.com> - 2016-05-31 20:50 +0200
  Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register  mappings into one table Sebastian Reichel <sre@kernel.org> - 2016-06-10 03:30 +0200

csiph-web