Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled
Date	2016-06-09 22:50 +0200
Message-ID	<rIf3P-31O-11@gated-at.bofh.it> (permalink)
References	<rCCcO-76f-17@gated-at.bofh.it> <rCCcO-76f-15@gated-at.bofh.it> <rD8w3-1sN-27@gated-at.bofh.it> <rDbDz-3vK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

>  The coherency is not dropped here. dma_map/unmap used
>  makes the buffer coherent before passing it to
>  dmaengine. Previously it was not required.
>  I can add this in description if its not clear.

Please do.

> 
>  >> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >>  		}
> >>  	}
> >>
> >> +	idx = 0;
> >> +
> >
> >This looks like an unrelated change.
>     Ha, wrong. This should have been in a separate patch.

Exactly this is what I meant with "unrelated" :)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is  enabled Wolfram Sang <wsa@the-dreams.de> - 2016-06-09 22:50 +0200

csiph-web