Re: [PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties
Date	2016-06-09 21:10 +0200
Message-ID	<rIdv3-27R-3@gated-at.bofh.it> (permalink)
References	<rGseS-6NZ-7@gated-at.bofh.it> <rHRbc-4cI-11@gated-at.bofh.it> <rHRNU-4rG-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 8, 2016 at 2:51 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> Hi,
>
> On Wed, Jun 08, 2016 at 02:18:42PM -0500, Rob Herring wrote:
>> On Sun, Jun 05, 2016 at 01:24:02AM +0300, Aaro Koskinen wrote:
>> > Document cavium-pip rx-delay/tx-delay properties. Currently the board
>> > specific values need to be hardcoded in the platform code, which we
>> > want to avoid when moving to DT-only booting.
>> >
>> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> > ---
>> >  Documentation/devicetree/bindings/net/cavium-pip.txt | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/net/cavium-pip.txt b/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > index 7dbd158..edbf411 100644
>> > --- a/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > +++ b/Documentation/devicetree/bindings/net/cavium-pip.txt
>> > @@ -37,6 +37,10 @@ Properties for PIP port which is a child the PIP interface:
>> >
>> >  - phy-handle: Optional, see ethernet.txt file in the same directory.
>> >
>> > +- rx-delay: Delay value for RGMII receive clock. Optional. Disabled if 0.
>> > +
>> > +- tx-delay: Delay value for RGMII transmit clock. Optional. Disabled if 0.
>>
>> What are the units? Use standard unit suffix if in ns, us, etc.
>
> This is a raw register value, and the mapping to actual delay varies
> depending on HW, AFAIK.

Then state that in the description.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Documentation/devicetree: document cavium-pip rx-delay/tx-delay properties Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-06-05 00:30 +0200
  Re: [PATCH] Documentation/devicetree: document cavium-pip  rx-delay/tx-delay properties Rob Herring <robh@kernel.org> - 2016-06-08 21:20 +0200
    Re: [PATCH] Documentation/devicetree: document cavium-pip  rx-delay/tx-delay properties Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-06-08 22:00 +0200
      Re: [PATCH] Documentation/devicetree: document cavium-pip  rx-delay/tx-delay properties Rob Herring <robh@kernel.org> - 2016-06-09 21:10 +0200

csiph-web