Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1418536

Re: linux-next: build warnings after merge of the kbuild tree

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: linux-next: build warnings after merge of the kbuild tree
Date 2016-06-09 20:00 +0200
Message-ID <rIcpj-1d0-3@gated-at.bofh.it> (permalink)
References <rHXTk-8w3-7@gated-at.bofh.it> <rHYmm-en-7@gated-at.bofh.it> <rHZs5-1ac-7@gated-at.bofh.it> <rI5QR-5eV-1@gated-at.bofh.it> <rIc5X-13V-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jun 9, 2016 at 10:37 AM, Emese Revfy <re.emese@gmail.com> wrote:
> On Thu, 9 Jun 2016 12:57:16 +0200
> Michal Marek <mmarek@suse.cz> wrote:
>
>> Dne 9.6.2016 v 06:05 Stephen Rothwell napsal(a):
>> > On Wed, 8 Jun 2016 19:56:38 -0700 Kees Cook <keescook@chromium.org> wrote:
>> >> Ah, yes, that should default to off. We'll get a fix landed ASAP.
>> >
>> > Note that this was an allmodconfig build.  The default is 'n', but
>> > allmodconfig will turn it on (as will allyesconfig).
>>
>> I guess we should make GCC_PLUGINS depend on !COMPILE_TEST. Actually I
>> thought this was already the case, but it is not.
>
> Is it really necessary to disable all gcc plugins or would it be enough
> to disable only the cyc_complexity plugin?

I think disabling (depend on !COMPILE_TEST) plugins that have
non-actionable output make sense. For example, in the future, things
like constify or initify may produce warnings that are "real" in the
sense that they have detected situations that should be fixed in the
code. In a perfect world, we would include those fixes ahead of the
new plugin to keep Stephen from going crazy. :)

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

linux-next: build warnings after merge of the kbuild tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-09 04:30 +0200
  Re: linux-next: build warnings after merge of the kbuild tree Kees Cook <keescook@chromium.org> - 2016-06-09 05:00 +0200
    Re: linux-next: build warnings after merge of the kbuild tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-09 06:10 +0200
      Re: linux-next: build warnings after merge of the kbuild tree Michal Marek <mmarek@suse.cz> - 2016-06-09 13:00 +0200
        Re: linux-next: build warnings after merge of the kbuild tree Emese Revfy <re.emese@gmail.com> - 2016-06-09 19:40 +0200
          Re: linux-next: build warnings after merge of the kbuild tree Kees Cook <keescook@chromium.org> - 2016-06-09 20:00 +0200
      Re: linux-next: build warnings after merge of the kbuild tree Michael Ellerman <mpe@ellerman.id.au> - 2016-06-09 13:20 +0200
  Re: linux-next: build warnings after merge of the kbuild tree Emese Revfy <re.emese@gmail.com> - 2016-06-09 19:40 +0200

csiph-web