Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1418447

Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

Show all headers | View raw

On 06/09/2016 01:50 AM, Odzioba, Lukasz wrote:
> On 08-06-16 17:31:00, Dave Hansen wrote:
>> Do we have any statistics that tell us how many pages are sitting the
>> lru pvecs?  Although this helps the problem overall, don't we still have
>> a problem with memory being held in such an opaque place?
> 
>>From what I observed the problem is mainly with lru_add_pvec, the
> rest is near empty for most of the time. I added debug code to
>  lru_add_drain_all(), to see sizes of the lru pvecs when I debugged this.
> 
> Among lru_add_pvec, lru_rotate_pvecs, lru_deactivate_file_pvecs, 
> lru_deactivate_pvecs, activate_page_pvecs almost all (3-4GB) of the 
> missing memory was in lru_add_pvec, the rest was almost always empty.

Does your workload put large pages in and out of those pvecs, though?
If your system doesn't have any activity, then all we've shown is that
they're not a problem when not in use.  But what about when we use them?

Have you, for instance, tried this on a system with memory pressure?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival Lukasz Odzioba <lukasz.odzioba@intel.com> - 2016-06-08 16:40 +0200
  Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Michal Hocko <mhocko@kernel.org> - 2016-06-08 17:10 +0200
    RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-06-09 10:10 +0200
  Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Dave Hansen <dave.hansen@intel.com> - 2016-06-08 17:40 +0200
    Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Michal Hocko <mhocko@kernel.org> - 2016-06-08 18:10 +0200
      Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Dave Hansen <dave.hansen@intel.com> - 2016-06-08 18:40 +0200
        Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Michal Hocko <mhocko@kernel.org> - 2016-06-09 14:30 +0200
    RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-06-09 11:00 +0200
      Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page  arrival Dave Hansen <dave.hansen@intel.com> - 2016-06-09 17:50 +0200

csiph-web