Groups > linux.kernel > #1419987

Re: [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count
Date	2016-06-11 17:40 +0200
Message-ID	<rITaV-4Oy-1@gated-at.bofh.it> (permalink)
References	<rIGQp-5BE-3@gated-at.bofh.it> <rIH9L-5HL-3@gated-at.bofh.it> <rIH9L-5HL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> The pp_debugfs_dir is already initialized by the module init function.
> If it doesn't exist here, I think we should just return instead of
> trying again.  It's also worth noting, though it is probably no harm,
> the code here does not check debugfs_initialized().

>> +static int __init tool_init(void)
>
> This should be pp_init() not tool_init().

Yup, this is just sloppy copying on my part. I copied from two different 
places. I'll fix these oversights.

Thanks,

Logan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count Allen Hubbe <allenbh@gmail.com> - 2016-06-11 04:50 +0200
  Re: [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping  count Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 17:40 +0200

csiph-web