Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419889
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] block: correctly fallback for zeroout |
| Date | 2016-06-11 04:00 +0200 |
| Message-ID | <rIGno-55z-27@gated-at.bofh.it> (permalink) |
| References | <rHhhn-6ua-3@gated-at.bofh.it> <rIk3v-6Kf-7@gated-at.bofh.it> <rIGno-55z-29@gated-at.bofh.it> |
| Organization | Oracle Corporation |
>>>>> "Shaohua" == Shaohua Li <shli@fb.com> writes: Shaohua, >> What does the extra io_err buy us? Just have this function return an >> error. And then in blkdev_issue_discard if you get -EOPNOTSUPP you >> special case it there. Shaohua> The __blkdev_issue_discard returns -EOPNOTSUPP if disk doesn't Shaohua> support discard. in that case, blkdev_issue_discard doesn't Shaohua> return 0. blkdev_issue_discard only returns 0 if IO error is Shaohua> -EOPNOTSUPP. Oh, I see. The sanity checks are now in __blkdev_issue_discard() so there is no way to distinguish between -EOPNOTSUPP and the other -EOPNOTSUPP. *sigh* I am OK with your patch as a stable fix but this really needs to be fixed up properly. -- Martin K. Petersen Oracle Linux Engineering
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-10 04:10 +0200
Re: [PATCH V2] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-11 04:00 +0200
Re: [PATCH V2] block: correctly fallback for zeroout Christoph Hellwig <hch@infradead.org> - 2016-06-13 10:30 +0200
Re: [PATCH V2] block: correctly fallback for zeroout Mike Snitzer <snitzer@redhat.com> - 2016-06-14 20:40 +0200
Re: [PATCH V2] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-15 04:40 +0200
Re: [PATCH V2] block: correctly fallback for zeroout Mike Snitzer <snitzer@redhat.com> - 2016-06-15 04:50 +0200
Re: [PATCH V2] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-15 04:20 +0200
Re: [PATCH V2] block: correctly fallback for zeroout Sitsofe Wheeler <sitsofe@gmail.com> - 2016-06-15 23:30 +0200
csiph-web